From 0cb1cb0c551876ba4fbf314b3ba34b9a14fcbcd3 Mon Sep 17 00:00:00 2001
From: B3ni <ballobeni08@gmail.com>
Date: Sun, 6 Jul 2025 00:26:24 +0200
Subject: [PATCH] Enhance EntityMetadataUpdateProcessor to ensure
 container/storage metadata is always synchronized to visible players and
 allow updates from any player for such metadata.

---
 .../EntityMetadataUpdateProcessor.cs           | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs b/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
index 1272ee2..7d20020 100644
--- a/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
+++ b/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
@@ -38,20 +38,34 @@ public class EntityMetadataUpdateProcessor : AuthenticatedPacketProcessor<Entity
         foreach (Player player in playerManager.GetConnectedPlayers())
         {
             bool updateVisibleToPlayer = player.CanSee(entity);
+            
+            // Always sync container/storage metadata to all visible players
+            bool isContainerMetadata = IsContainerRelatedMetadata(packet.NewValue);
 
-            if (player != sendingPlayer && updateVisibleToPlayer)
+            if (player != sendingPlayer && (updateVisibleToPlayer || isContainerMetadata))
             {
                 player.SendPacket(packet);
             }
         }
     }
 
+    private bool IsContainerRelatedMetadata(EntityMetadata metadata)
+    {
+        // Check if metadata is related to containers/storage
+        return metadata.GetType().Name.Contains("Container") || 
+               metadata.GetType().Name.Contains("Storage") ||
+               metadata.GetType().Name.Contains("Inventory");
+    }
+
     private bool TryProcessMetadata(Player sendingPlayer, Entity entity, EntityMetadata metadata)
     {
         return metadata switch
         {
             PlayerMetadata playerMetadata => ProcessPlayerMetadata(sendingPlayer, entity, playerMetadata),
-
+            
+            // Always allow container/storage metadata updates for proper sync
+            _ when IsContainerRelatedMetadata(metadata) => true,
+            
             // Allow metadata updates from any player by default
             _ => true
         };