From 1b3da7bece033e1f60621ffcc99680130f202ffa Mon Sep 17 00:00:00 2001
From: B3ni <ballobeni08@gmail.com>
Date: Sun, 6 Jul 2025 00:25:54 +0200
Subject: [PATCH] Refactor EntityMetadataUpdateProcessor to simplify metadata
 update logic and remove container-related checks

---
 .../EntityMetadataUpdateProcessor.cs          | 20 +++----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs b/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
index 22f625b..1272ee2 100644
--- a/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
+++ b/NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs
@@ -38,34 +38,20 @@ public class EntityMetadataUpdateProcessor : AuthenticatedPacketProcessor<Entity
         foreach (Player player in playerManager.GetConnectedPlayers())
         {
             bool updateVisibleToPlayer = player.CanSee(entity);
-            
-            // Always sync container/storage metadata to all visible players
-            bool isContainerMetadata = IsContainerRelatedMetadata(packet.NewValue);
 
-            if (player != sendingPlayer && (updateVisibleToPlayer || isContainerMetadata))
+            if (player != sendingPlayer && updateVisibleToPlayer)
             {
                 player.SendPacket(packet);
             }
         }
     }
 
-    private bool IsContainerRelatedMetadata(EntityMetadata metadata)
-    {
-        // Check if metadata is related to containers/storage
-        return metadata.GetType().Name.Contains("Container") || 
-               metadata.GetType().Name.Contains("Storage") ||
-               metadata.GetType().Name.Contains("Inventory");
-    }
-
     private bool TryProcessMetadata(Player sendingPlayer, Entity entity, EntityMetadata metadata)
     {
         return metadata switch
         {
             PlayerMetadata playerMetadata => ProcessPlayerMetadata(sendingPlayer, entity, playerMetadata),
-            
-            // Always allow container/storage metadata updates for proper sync
-            _ when IsContainerRelatedMetadata(metadata) => true,
-            
+
             // Allow metadata updates from any player by default
             _ => true
         };
@@ -87,4 +73,4 @@ public class EntityMetadataUpdateProcessor : AuthenticatedPacketProcessor<Entity
         Log.WarnOnce($"Player {sendingPlayer.Name} tried updating metadata of another player's entity {entity.Id}");
         return false;
     }
-}
+}
\ No newline at end of file