Enhance EntityMetadataUpdateProcessor to ensure container/storage metadata is always synchronized to visible players and allow updates from any player for such metadata.

This commit is contained in:
2025-07-06 00:26:24 +02:00
parent 1b3da7bece
commit 0cb1cb0c55

View File

@@ -38,20 +38,34 @@ public class EntityMetadataUpdateProcessor : AuthenticatedPacketProcessor<Entity
foreach (Player player in playerManager.GetConnectedPlayers()) foreach (Player player in playerManager.GetConnectedPlayers())
{ {
bool updateVisibleToPlayer = player.CanSee(entity); bool updateVisibleToPlayer = player.CanSee(entity);
// Always sync container/storage metadata to all visible players
bool isContainerMetadata = IsContainerRelatedMetadata(packet.NewValue);
if (player != sendingPlayer && updateVisibleToPlayer) if (player != sendingPlayer && (updateVisibleToPlayer || isContainerMetadata))
{ {
player.SendPacket(packet); player.SendPacket(packet);
} }
} }
} }
private bool IsContainerRelatedMetadata(EntityMetadata metadata)
{
// Check if metadata is related to containers/storage
return metadata.GetType().Name.Contains("Container") ||
metadata.GetType().Name.Contains("Storage") ||
metadata.GetType().Name.Contains("Inventory");
}
private bool TryProcessMetadata(Player sendingPlayer, Entity entity, EntityMetadata metadata) private bool TryProcessMetadata(Player sendingPlayer, Entity entity, EntityMetadata metadata)
{ {
return metadata switch return metadata switch
{ {
PlayerMetadata playerMetadata => ProcessPlayerMetadata(sendingPlayer, entity, playerMetadata), PlayerMetadata playerMetadata => ProcessPlayerMetadata(sendingPlayer, entity, playerMetadata),
// Always allow container/storage metadata updates for proper sync
_ when IsContainerRelatedMetadata(metadata) => true,
// Allow metadata updates from any player by default // Allow metadata updates from any player by default
_ => true _ => true
}; };